Backport PR #21913 on branch v3.5.x (Make colorbar boundaries work again)#21926
Merged
QuLogic merged 2 commits intomatplotlib:v3.5.xfrom Dec 11, 2021
Merged
Conversation
- `__scale = "manual"` doesn't exist anymore since d1c5a6a. - Shorten Boundary/NoNorm inversion and norm._scale check. - No need to define `x` well before its use point, and no need to make it an array explicitly.
greglucas
approved these changes
Dec 11, 2021
Contributor
greglucas
left a comment
There was a problem hiding this comment.
I tested it with the 3d example from the issue and everything looks good there with the boundaries being respected.
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Backport #21913, and also #21137 to fix conflicts.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).