Skip to content

Custom sessions#716

Merged
munrojm merged 2 commits intomainfrom
enhancement/custom_session
Dec 8, 2022
Merged

Custom sessions#716
munrojm merged 2 commits intomainfrom
enhancement/custom_session

Conversation

@munrojm
Copy link
Copy Markdown
Member

@munrojm munrojm commented Dec 8, 2022

  • Ability added to pass an already instantiated Session object to MPRester
  • Custom headers are now passed to each request

@munrojm munrojm added the release:patch Patch release label Dec 8, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 80.94% // Head: 81.17% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (06f7f51) compared to base (6bf1791).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   80.94%   81.17%   +0.22%     
==========================================
  Files          36       36              
  Lines        1758     1758              
==========================================
+ Hits         1423     1427       +4     
+ Misses        335      331       -4     
Impacted Files Coverage Δ
mp_api/client/core/client.py 89.18% <100.00%> (ø)
mp_api/client/mprester.py 59.72% <100.00%> (+1.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit ac4bb36 into main Dec 8, 2022
@munrojm munrojm deleted the enhancement/custom_session branch December 8, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch Patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants