Skip to content

Allow the pmgrc file to be read for the MPREster settings#708

Merged
munrojm merged 3 commits intomaterialsproject:mainfrom
jmmshn:patch_setting
Nov 16, 2022
Merged

Allow the pmgrc file to be read for the MPREster settings#708
munrojm merged 3 commits intomaterialsproject:mainfrom
jmmshn:patch_setting

Conversation

@jmmshn
Copy link
Copy Markdown
Contributor

@jmmshn jmmshn commented Nov 16, 2022

The order should be (User setting in python) > (environment variables) > (pmgrc.yaml settings)

@jmmshn jmmshn marked this pull request as draft November 16, 2022 21:44
@jmmshn jmmshn marked this pull request as ready for review November 16, 2022 21:46
@munrojm
Copy link
Copy Markdown
Member

munrojm commented Nov 16, 2022

Thanks @jmmshn! Once you confirm the tests have passed for you locally, I will merge here.

@munrojm munrojm added the release:patch Patch release label Nov 16, 2022
@jmmshn
Copy link
Copy Markdown
Contributor Author

jmmshn commented Nov 16, 2022

So I tested the behavior for the progress bar and it works.
I'm not sure how PMG_MAPI_KEY is handled maybe we should also move that under this setup.

@munrojm munrojm merged commit 80f4686 into materialsproject:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch Patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants