Skip to content

Insert missing comma in setup.py#697

Merged
munrojm merged 1 commit intomaterialsproject:mainfrom
sezelt:patch-1
Oct 21, 2022
Merged

Insert missing comma in setup.py#697
munrojm merged 1 commit intomaterialsproject:mainfrom
sezelt:patch-1

Conversation

@sezelt
Copy link
Copy Markdown
Contributor

@sezelt sezelt commented Oct 21, 2022

There is a missing comma on line 36 of setup.py that causes "emmet-core[all]>=0.36.4" and "custodian" to be interpreted as one string.

This then corrupts the poetry.lock that gets generated for projects that depend on mp-api, e.g.

[[package]]
name = "mp-api"
version = "0.29.2"
description = "API Server for the Materials Project"
category = "main"
optional = false
python-versions = ">=3.8"

[package.dependencies]
emmet-core = ">=0.36.4"
monty = ">=2021.3.12"
msgpack = "*"
pymatgen = ">=2022.3.7"
requests = ">=2.23.0"
typing-extensions = ">=3.7.4.1"

[package.extras]
all = ["boto3", "emmet-core[all] (>=0.36.4custodian)", "mpcontribs-client"]

yields

[...]
Installing dependencies from lock file

Could not parse version constraint: >=0.36.4custodian

@sezelt
Insert missing comma in setup.py
e698761 
There is a missing comma on line 36 of `setup.py` that causes `"emmet-core[all]>=0.36.4"` and `"custodian"` to be interpreted as one string.
@sezelt sezelt mentioned this pull request Oct 21, 2022
Merged
5 tasks
@munrojm munrojm added the release:patch Patch release label Oct 21, 2022
@munrojm
Copy link
Copy Markdown
Member

munrojm commented Oct 21, 2022

Thank you @sezelt!

@munrojm munrojm merged commit ebe7c43 into materialsproject:main Oct 21, 2022
@sezelt sezelt deleted the patch-1 branch October 21, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release:patch Patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sezelt @munrojm