Skip to content

Smart chunk with max URL length consideration#695

Merged
munrojm merged 9 commits intomainfrom
enhancement/max_http_url
Oct 20, 2022
Merged

Smart chunk with max URL length consideration#695
munrojm merged 9 commits intomainfrom
enhancement/max_http_url

Conversation

@munrojm
Copy link
Copy Markdown
Member

@munrojm munrojm commented Oct 19, 2022

This PR implements smarter parallel chunking of request URLs that takes into account a max character number for HTTP URLs.

A new settings parameter is used to define the max character number which defaults to 2000.

@munrojm munrojm added the release:patch Patch release label Oct 19, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 87.70% // Head: 83.35% // Decreases project coverage by -4.34% ⚠️

Coverage data is based on head (e7e0432) compared to base (72eafaa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   87.70%   83.35%   -4.35%     
==========================================
  Files          36       36              
  Lines        1667     1682      +15     
==========================================
- Hits         1462     1402      -60     
- Misses        205      280      +75     
Impacted Files Coverage Δ
mp_api/client/core/client.py 85.28% <100.00%> (-3.39%) ⬇️
mp_api/client/core/settings.py 89.47% <100.00%> (+0.58%) ⬆️
mp_api/client/mprester.py 66.98% <0.00%> (-19.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit d3f7687 into main Oct 20, 2022
@munrojm munrojm deleted the enhancement/max_http_url branch December 6, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch Patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants