Support single values instead of (min, max) tuples as summary search filters#672
Merged
munrojm merged 1 commit intomaterialsproject:mainfrom Sep 23, 2022
janosh:main
Merged
Support single values instead of (min, max) tuples as summary search filters#672munrojm merged 1 commit intomaterialsproject:mainfrom janosh:main
munrojm merged 1 commit intomaterialsproject:mainfrom
janosh:main
Conversation
e.g. num_elements=1 instead of num_elements=[1, 1]
Member
Author
|
@munrojm I think the CI errors here might be unrelated? try:
data = json.loads(response.text)["detail"]
except (JSONDecodeError, KeyError):
data = f"Response {response.text}"
if isinstance(data, str):
message = data
else:
try:
message = ", ".join(
f"{entry['loc'][1]} - {entry['msg']}" for entry in data
)
except (KeyError, IndexError):
message = str(data)
raise MPRestError(
f"REST query returned with error status code {response.status_code} "
f"on URL {response.url} with message:\n{message}"
)
mp_api.client.core.client.MPRestError: REST query returned with error status code 401 on URL https://api.materialsproject.org/bonds/?_all_fields=True&material_ids=mp-149&_limit=1 with message:
Response {
"message":"No API key found in request"
} |
Member
|
@janosh, yes sorry for not getting back to you on this. If your local tests have passed I am good with merging. |
Member
Author
|
Ah, I'd previously only run the mp_api.client.core.client.MPRestError: REST query returned with error status code 504 on URL https://api.materialsproject.org/materials/?deprecated=False&exclude_elements=Si&_all_fields=True&_limit=1 with message:
E Server timed out trying to obtain data. Try again with a smaller request. |
Member
|
Yup, no worries. Thanks for the change! Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query currently errors
with
since it should be
num_elements=[1, 1]instead ofnum_elements=1.The error message isn't very clear so one improvement might be to ask the user to pass a tuple instead. This PR instead converts the value to a tuple on the fly when detecting
int:In the case of summary.search, it converts all values to tuple when detecting
intorfloat.Let me know if that's an acceptable change?