Skip to content

Namespace package, material_ids parameters#659

Merged
munrojm merged 16 commits intomainfrom
enhancement/namespace
Aug 16, 2022
Merged

Namespace package, material_ids parameters#659
munrojm merged 16 commits intomainfrom
enhancement/namespace

Conversation

@munrojm
Copy link
Copy Markdown
Member

@munrojm munrojm commented Aug 16, 2022

  • client is now a namespace package of mp_api requiring MPRester imports to switch to from mp_api.client import MPRester
  • All endpoint with material_ids query parameters now have a proper parameter added to their client search methods

@munrojm munrojm added the release:minor Minor release bump label Aug 16, 2022
@munrojm munrojm closed this Aug 16, 2022
@munrojm munrojm reopened this Aug 16, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #659 (6993834) into main (394fc4c) will increase coverage by 2.05%.
The diff coverage is 89.05%.

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   85.06%   87.11%   +2.05%     
==========================================
  Files          36       37       +1     
  Lines        1513     1568      +55     
==========================================
+ Hits         1287     1366      +79     
+ Misses        226      202      -24     
Impacted Files Coverage Δ
mp_api/client/core/utils.py 87.50% <ø> (ø)
mp_api/client/matproj.py 0.00% <ø> (ø)
mp_api/client/routes/alloys.py 61.11% <42.85%> (ø)
mp_api/client/routes/summary.py 98.21% <75.00%> (ø)
mp_api/client/routes/electronic_structure.py 89.36% <83.33%> (ø)
mp_api/client/routes/materials.py 76.47% <83.33%> (ø)
mp_api/client/routes/oxidation_states.py 93.10% <83.33%> (ø)
mp_api/client/routes/bonds.py 93.33% <85.71%> (ø)
mp_api/client/routes/dielectric.py 92.85% <85.71%> (ø)
mp_api/client/routes/electrodes.py 93.18% <85.71%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@munrojm munrojm merged commit ebd426d into main Aug 16, 2022
@munrojm munrojm deleted the enhancement/namespace branch August 18, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:minor Minor release bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants