Add cache example to README#146
Merged
mre merged 4 commits intolycheeverse:masterfrom Jul 27, 2022
Merged
Conversation
tooomm
commented
Jul 16, 2022
Member
|
Great idea, I like it! Should we add another step at the end which stores the cache for the next run? I'd assume that's what most people would want to do. Apart from that it looks fine. |
tooomm
commented
Jul 18, 2022
Contributor
Author
I updated the docs accordingly, and thanks for taking care of including the explanation. 👍 |
Member
|
Noice! Let's gooo! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such an example never made it to the docs after the feature got introduced (lycheeverse/lychee#443).
Now, that lycheeverse/lychee#647 is resolved and
--cacheworks again... 👍What do you think about my approach and the cache setup?
Would you adjust the default cache age value, or do you think some comments could be helpful?