Only append markdown if format isn't JSON#101
Merged
mre merged 1 commit intolycheeverse:masterfrom Apr 19, 2022
Merged
Conversation
Member
|
That works. However I'm wondering if we should check if the format is Markdown instead. Would cover all cases. |
Member
|
For some background: we only want to append a Markdown link if the format is Markdown. |
Contributor
Author
|
I noticed there were other formats supported by lychee, but I wasn't sure if they were 'markdown-ish' or not |
Member
|
Yeah there are others. Currently we have compact, detailed, json, and markdown. I'd say we only want to add the link for the markdown format. The others are plaintext or JSON. |
Contributor
Author
|
Updated to just apply to |
Member
|
Shouldn't it be two equal signs? if [ "${INPUT_FORMAT}" == "markdown" ]; then
echo "[Full Github Actions output](${GITHUB_WORKFLOW_URL})" >> "${INPUT_OUTPUT}"
fi |
Contributor
Author
|
argh.. mis-read a reference page. |
Member
|
Thanks for the contribution @flcdrg. 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100