Allow Pathlike objects for file arguments#337
Merged
scoder merged 7 commits intolxml:masterfrom Feb 12, 2022
Merged
Conversation
Added `_isStringOrPathLike` typecheck which checks for the existence of `__fspath__` for python 3.6+. `_encodeFilename` in apihelpers uses `os.fspath` to resolve thes paths
`iterparse` already allowed it, but a test is added.
_ElementTree.write_c14n
scoder
reviewed
Jan 27, 2022
Member
scoder
left a comment
There was a problem hiding this comment.
Cool, very nice. I think we should backport it, though. There is no reason why this couldn't work in Py<3.6 if someone cares to define __fspath__ on some object, such as a backported pathlib.
instead of checking for __fspath__ multiple times a cython function _getFSPathOrObject is added which calls the __fspath__ attribute if it exists For python 3.6+ this function uses PyOS_FSPath
2f95938 to
8a2bbee
Compare
scoder
reviewed
Jan 29, 2022
Co-authored-by: scoder <stefan_ml@behnel.de>
Member
|
Thanks! |
janssenhenning
added a commit
to JuDFTteam/masci-tools
that referenced
this pull request
Feb 17, 2022
for all of the API lxml/lxml#337 This allows to eliminate some corner cases in the fleur parser
janssenhenning
added a commit
to JuDFTteam/masci-tools
that referenced
this pull request
Feb 23, 2022
for all of the API lxml/lxml#337 This allows to eliminate some corner cases in the fleur parser
janssenhenning
added a commit
to JuDFTteam/masci-tools
that referenced
this pull request
Feb 25, 2022
for all of the API lxml/lxml#337 This allows to eliminate some corner cases in the fleur parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://bugs.launchpad.net/lxml/+bug/1820837