[#3145] byteOffset of typedArray is not handled properly#3146
Merged
lovell merged 2 commits intolovell:mainfrom Mar 27, 2022
Merged
[#3145] byteOffset of typedArray is not handled properly#3146lovell merged 2 commits intolovell:mainfrom
lovell merged 2 commits intolovell:mainfrom
Conversation
Owner
|
Thank you very much for the PR. Is it possible to add a test for this? |
Contributor
Author
Owner
|
Thanks for the updates. It looks like this PR was affected by today's GitHub Actions outage as the CI job is still in a queued and non-cancellable state - see https://github.com/lovell/sharp/actions/runs/2021845098 Hopefully the backlog will clear soon and we can get this merged. |
Owner
|
It looks like those CI jobs aren't going to run. Please can you rebase against the latest upstream/main branch and push to see if that might be enough to force the tests to run. |
de0387f to
bcd7f3a
Compare
Contributor
Author
|
ok, i did rebase. |
Owner
|
Thank you! |
lovell
added a commit
that referenced
this pull request
Mar 28, 2022
martinj
pushed a commit
to aptoma/sharp
that referenced
this pull request
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3145