Emit close event when stream is complete#2976
Merged
lovell merged 1 commit intolovell:mainfrom Nov 17, 2021
Merged
Conversation
Owner
|
Thank you very much for the PR. Are you able to add a couple of unit tests to cover this logic? This should help prevent any future regression. |
Contributor
Author
|
Sure thing! I'll take a look over the next couple of days when I get a chance. |
Owner
|
Brilliant, thank you Drian! |
lovell
added a commit
that referenced
this pull request
Nov 17, 2021
Y2zz
pushed a commit
to Y2zz/sharp
that referenced
this pull request
Feb 26, 2022
Y2zz
pushed a commit
to Y2zz/sharp
that referenced
this pull request
Feb 26, 2022
|
Hey guys ! |
Owner
|
@arsonik If you still require help, please open a new question at https://github.com/lovell/sharp/issues/new?labels=question&template=question.md - please remember that you'll need to remove non-sharp dependencies from your question, including removing any possible networking problems, as part of this. |
Repository owner
locked and limited conversation to collaborators
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2897
Fixes #2898