Check loaded bindings not only on Windows#3132
Merged
lovell merged 1 commit intolovell:mainfrom Mar 14, 2022
Merged
Conversation
3 tasks
Owner
|
Perhaps we should only additionally show this help when the error message mentions a symbol-related problem? if (process.platform === 'win32' || /symbol/.test(err.message)) { ... |
fcc00ce to
814a726
Compare
814a726 to
9fc492f
Compare
Contributor
Author
|
I rebased and amended the commit with your suggestion, therefore I force-pushed to have a single commit as specified in the CONTRIBUTING.md |
Owner
|
C'est super, merci Marvin. |
Contributor
Author
|
Merci à toi ! |
martinj
pushed a commit
to aptoma/sharp
that referenced
this pull request
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.