fix: Adds guards for undefiend callback functions in shutdown method#972
Merged
nomiddlename merged 1 commit intolog4js-node:masterfrom Jan 29, 2020
Merged
fix: Adds guards for undefiend callback functions in shutdown method#972nomiddlename merged 1 commit intolog4js-node:masterfrom
nomiddlename merged 1 commit intolog4js-node:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 98.61% 98.61% +<.01%
==========================================
Files 25 25
Lines 1012 1013 +1
==========================================
+ Hits 998 999 +1
Misses 14 14
Continue to review full report at Codecov.
|
Collaborator
|
Thanks for picking this up. |
Collaborator
|
Published to npm in log4js@6.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #971