You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to #1089, it's due to the way EventEmitter works.
If there is no listener to the 'error' event, the EventEmitter additionally throws the error, which in turn becomes uncaughtException that terminates the Node.js process. This portion has been overlooked and this PR patches it.
Events
Error events
When an error occurs within an EventEmitter instance, the typical action is for an 'error' event to be emitted. These are treated as special cases within Node.js.
If an EventEmitter does not have at least one listener registered for the 'error' event, and an 'error' event is emitted, the error is thrown, a stack trace is printed, and the Node.js process exits.
constmyEmitter=newMyEmitter();myEmitter.emit('error',newError('whoops!'));// Throws and crashes Node.js
To guard against crashing the Node.js process the domain module can be used. (Note, however, that the domain module is deprecated.)
As a best practice, listeners should always be added for the 'error' events.
constmyEmitter=newMyEmitter();myEmitter.on('error',(err)=>{console.error('whoops! there was an error');});myEmitter.emit('error',newError('whoops!'));// Prints: whoops! there was an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.