build: upgrade go directive in go.mod to 1.17#2049
Merged
lammel merged 1 commit intolabstack:masterfrom Jan 24, 2022
Juneezee:go1.17
Merged
build: upgrade go directive in go.mod to 1.17#2049lammel merged 1 commit intolabstack:masterfrom Juneezee:go1.17
go directive in go.mod to 1.17#2049lammel merged 1 commit intolabstack:masterfrom
Juneezee:go1.17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2049 +/- ##
==========================================
+ Coverage 91.57% 91.77% +0.20%
==========================================
Files 33 36 +3
Lines 2921 2968 +47
==========================================
+ Hits 2675 2724 +49
+ Misses 157 156 -1
+ Partials 89 88 -1
Continue to review full report at Codecov.
|
Contributor
aldas
approved these changes
Jan 24, 2022
Contributor
aldas
left a comment
There was a problem hiding this comment.
I was little bit vary of this because of older Go versions. This is due my ignorance of that directive. But we already have go 1.15 and still support 1.14 and nobody is complaining - so it is probably ok.
This commit enables support for module graph pruning and lazy module loading for projects that are at Go 1.17 or higher. Reference: https://go.dev/ref/mod#go-mod-file-go Reference: https://go.dev/ref/mod#graph-pruning Reference: https://go.dev/ref/mod#lazy-loading Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
godirective ingo.modfile by runninggo mod tidy -go=1.17to enable module graph pruning and lazy module loading.Note 1: This does not prevent users with earlier Go versions from successfully building packages from this module.
Note 2: The additional
requiredirective is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.