Fixed a problem that returned wrong content-encoding when the gzip co…#1921
Merged
aldas merged 4 commits intolabstack:masterfrom Dec 15, 2021
Merged
Fixed a problem that returned wrong content-encoding when the gzip co…#1921aldas merged 4 commits intolabstack:masterfrom
aldas merged 4 commits intolabstack:masterfrom
Conversation
…mpressed content was empty
Codecov Report
@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
+ Coverage 90.97% 91.33% +0.35%
==========================================
Files 32 33 +1
Lines 2792 2872 +80
==========================================
+ Hits 2540 2623 +83
+ Misses 161 159 -2
+ Partials 91 90 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
what is the status of this pr? @aldas |
aldas
requested changes
Dec 4, 2021
Contributor
Author
|
ping @aldas |
aldas
approved these changes
Dec 15, 2021
Contributor
aldas
left a comment
There was a problem hiding this comment.
LGTM, sorry for delay, these Github messages get sometimes buried in my mailbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a problem that returned wrong content-encoding when the gzip compressed content was empty.
gzip.Writerwrites a gzip header if Write is called even once, and does not return the length of the header.we need to record the Write call and make sure that the gzip header is written.