Recover middleware should not log panic for aborted handler (fix #2133)#2134
Merged
lammel merged 1 commit intolabstack:masterfrom Mar 15, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2134 +/- ##
=======================================
Coverage 92.10% 92.11%
=======================================
Files 37 37
Lines 3028 3030 +2
=======================================
+ Hits 2789 2791 +2
Misses 150 150
Partials 89 89
Continue to review full report at Codecov.
|
Contributor
|
@lammel please review |
lammel
approved these changes
Mar 15, 2022
Contributor
lammel
left a comment
There was a problem hiding this comment.
Also looks good to me.
I think an end2end test is nice to have, but not really required, so let's merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for the issue #2133
The fix is in explicit check in recover middleware defer function to re-throw (panic) the
http.ErrAbortHandlererror.This specific error is recovered in
net/http/server.goand per default ignored for logging.https://github.com/golang/go/blob/88be85f18bf0244a2470fdf6719e1b5ca5a5e50a/src/net/http/server.go#L1799