Add example about node label management#268
Merged
mbohlool merged 1 commit intokubernetes-client:masterfrom Jul 5, 2017
Merged
Add example about node label management#268mbohlool merged 1 commit intokubernetes-client:masterfrom
mbohlool merged 1 commit intokubernetes-client:masterfrom
Conversation
mbohlool
suggested changes
Jun 25, 2017
Contributor
mbohlool
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Here are my comments. Also the pep8 check is failing that means there is a formatting issue with your code.
examples/add-node-label.py
Outdated
| @@ -0,0 +1,20 @@ | |||
| from pprint import pprint | |||
Contributor
There was a problem hiding this comment.
Add copyright header please.
examples/add-node-label.py
Outdated
| from kubernetes import client, config | ||
|
|
||
| config.load_kube_config() | ||
| client.configuration.debug = True |
Contributor
There was a problem hiding this comment.
We don't need this in the example.
examples/remove-node-label.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| from pprint import pprint | |||
Contributor
There was a problem hiding this comment.
We can add this to the previous example. right? in between we can also read the node and check to see if the label is there.
5e43187 to
96f9b1b
Compare
Contributor
Author
|
I applied all the chances your proposed. |
c4402c0 to
553f91a
Compare
Contributor
|
I think it is good to merge. Please fix pep8 check, more info here: https://travis-ci.org/kubernetes-incubator/client-python/jobs/249944871 Thanks. |
Show how to add/remove/change node labels. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
553f91a to
0a4b52a
Compare
mbohlool
approved these changes
Jul 5, 2017
yliaog
pushed a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
Use select.poll() for exec on linux/darwin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add example covering node label management as requested here.