On Mon, Nov 2, 2020 at 11:27 AM Rob Scott ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/apis/discovery/types.go <#92968 (comment)> : > + // terminating indicates that this endpoint is terminating. A nil value indicates an + // unknown state. Consumers should interpret this unknown state to mean that the + // endpoint is not terminating. Thanks for the context here, it was helpful to read through the previous conversation around this. One of the points that stood out to me was: Sending traffic to any pod that fails readiness seems like we're breaking API contract. I'm personally in favor of only falling back to {R, T} endpoints That makes it sound like there's no value in tracking endpoints that are !Ready && Terminating. As a variation of what Tim said above, maybe we could use 2 conditions that were defined as the following: ready: serving && !terminating draining: serving && terminating Those conditions should never be true at the same time. I'm not sure that draining is the appropriate term here, I just wanted to throw out an alternative to terminating since that may be too broad for what I'm suggesting. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#92968 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVCBUXN7WV2KGRWECMLSN4B3JANCNFSM4OWYAVFA> .