Skip to content

Admission webhook warnings#92667

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
liggitt:admission-warnings
Jul 2, 2020
Merged

Admission webhook warnings#92667
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
liggitt:admission-warnings

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Jun 30, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
part of https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1693-warnings and kubernetes/enhancements#1693

Does this PR introduce a user-facing change?:

Admission webhooks can now return warning messages that are surfaced to API clients, using the `.response.warnings` field in the admission review response.

/sig api-machinery
/assign @deads2k @smarterclayton

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2020
@liggitt liggitt force-pushed the admission-warnings branch 2 times, most recently from b28c37d to 2097981 Compare June 30, 2020 20:45
@liggitt liggitt changed the title WIP - Admission webhook warnings Admission webhook warnings Jun 30, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2020
@liggitt liggitt force-pushed the admission-warnings branch from 2097981 to 55f35e8 Compare June 30, 2020 21:30
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 30, 2020
@liggitt liggitt mentioned this pull request Jun 30, 2020
Closed
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jun 30, 2020

cc @thockin, since I know you're interested in ongoing use of warnings

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jun 30, 2020

/retest

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 30, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt force-pushed the admission-warnings branch from 55f35e8 to 715ac70 Compare June 30, 2020 23:51
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jul 1, 2020

/retest

deads2k
deads2k reviewed Jul 1, 2020
View reviewed changes
Comment thread staging/src/k8s.io/apiserver/pkg/endpoints/filters/warning.go Outdated
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jul 1, 2020

that came our very cleanly. One question about how we'll know this is happening, but lgtm otherwise.

/lgtm
/hold in case you want to log that this is happening at some level

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 1, 2020
liggitt added 2 commits July 1, 2020 12:14
@liggitt
Add warnings capability for admission webhooks
5eef60a
@liggitt
Generated code
03d3220 
Change-Id: I974a2cddc090fcb645b982959e06415a951b8f15
@liggitt liggitt force-pushed the admission-warnings branch from 715ac70 to 03d3220 Compare July 1, 2020 16:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jul 1, 2020

/priority important-soon
/hold cancel

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 1, 2020
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jul 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jul 1, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit f7a13de into kubernetes:master Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 2, 2020
@liggitt liggitt deleted the admission-warnings branch July 6, 2020 14:37
@liggitt liggitt mentioned this pull request Jul 6, 2020
Merged
@github-actions github-actions Bot mentioned this pull request Jul 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@smarterclayton smarterclayton

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

5 participants

@liggitt @k8s-ci-robot @fejta-bot @deads2k @smarterclayton