Skip to content

Move external facing podresources apis to staging#92632

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
RenaudWasTaken:move-podresources-api
Sep 15, 2020
Merged

Move external facing podresources apis to staging#92632
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
RenaudWasTaken:move-podresources-api

Conversation

@RenaudWasTaken
Copy link
Copy Markdown
Contributor

@RenaudWasTaken RenaudWasTaken commented Jun 30, 2020 •
edited
Loading

What type of PR is this?
/kind api-change
/area code-organization
/sig node

What this PR does / why we need it:
podresources API is external facing. Currently we are forcing folks to import them from k8s.io/kubernetes which is not optimal. We should instead make them available from the k8s.io/kubelet repo to make it easier for them.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer:
Note, for people who will be broken by this change (i.e: people pulling from kubernetes master), they can either:
a) Freeze the kubernetes version they rely on, which they already should, in the go.mod they should have something along the lines of

require (
        ...
	k8s.io/kubernetes v0.17.4
        ....
)

b) Change the import path:

sed -i 's#k8s.io/kubernetes/pkg/kubelet/apis/podresources/v1alpha1#k8s.io/kubelet/pkg/apis/podresources/v1alpha1#g" *.go
go mod tidy

/cc @dashpole @derekwaynecarr

Enhancement issue: kubernetes/enhancements#606
Current Kep: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/compute-device-assignment.md
Updated Kep: kubernetes/enhancements#1865

Note: Change is targeting current milestone and we expect to introduce v1 in the next release.
Also note that despite the API name, it is currently in beta (since 1.15).

Does this PR introduce a user-facing change?:

external facing API podresources is now available under k8s.io/kubelet/pkg/apis/

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/code-organization Issues or PRs related to kubernetes code organization size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 30, 2020
@RenaudWasTaken
Copy link
Copy Markdown
Contributor Author

RenaudWasTaken commented Jun 30, 2020

/assign @dims

Note that I followed the model of your PR: #83551

@RenaudWasTaken RenaudWasTaken force-pushed the move-podresources-api branch from d2089f7 to b0a6b92 Compare June 30, 2020 05:36
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 30, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@RenaudWasTaken RenaudWasTaken force-pushed the move-podresources-api branch from b0a6b92 to a8cb25a Compare June 30, 2020 08:14
@RenaudWasTaken
Copy link
Copy Markdown
Contributor Author

RenaudWasTaken commented Jun 30, 2020

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jun 30, 2020
SergeyKanzhelev
SergeyKanzhelev approved these changes Jun 30, 2020
View reviewed changes
Comment thread hack/update-generated-pod-resources-dockerized.sh Outdated
@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Jun 30, 2020

/assign @dashpole

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jun 30, 2020
Closed
@RenaudWasTaken RenaudWasTaken force-pushed the move-podresources-api branch from a8cb25a to 9419692 Compare June 30, 2020 21:17
@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Jul 1, 2020

/retest

@dashpole
Copy link
Copy Markdown
Contributor

dashpole commented Jul 6, 2020

/lgtm
/approve

Thanks @RenaudWasTaken

@dashpole
Copy link
Copy Markdown
Contributor

dashpole commented Jul 6, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@dims dims removed their assignment Jul 26, 2020
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 20, 2020
@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Aug 26, 2020

please see this PR merge policy change.
https://groups.google.com/g/kubernetes-dev/c/YXGBa6pxLzo

the milestone should be applied later in the cycle.
for Q you can ask in #sig-release.

thanks
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.20 milestone Aug 26, 2020
@RenaudWasTaken
Copy link
Copy Markdown
Contributor Author

RenaudWasTaken commented Aug 28, 2020

I'll probably wait a bit that regular maintenance restarts before rebasing this PR :) !
It's not critical to stability and doesn't fix any tests.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2020
@liggitt liggitt added this to the v1.20-phase-feature milestone Aug 28, 2020
@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Sep 9, 2020

I'll probably wait a bit that regular maintenance restarts before rebasing this PR :) !
It's not critical to stability and doesn't fix any tests.

@RenaudWasTaken this time came =) It's now in 1.20 milestone

@RenaudWasTaken
Copy link
Copy Markdown
Contributor Author

RenaudWasTaken commented Sep 9, 2020

Will take care of it this week then!

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 13, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, liggitt, RenaudWasTaken

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SergeyKanzhelev
SergeyKanzhelev reviewed Sep 14, 2020
View reviewed changes
Comment thread pkg/kubelet/server/server.go Outdated
Renaud Gaubert added 2 commits September 15, 2020 05:13
Move podresources api to k8s.io/kubelet/pkg/apis
6030445 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
run hack/update-vendor.sh
ba95a8c 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
Run gofmt
4eadf40 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
@RenaudWasTaken
Copy link
Copy Markdown
Contributor Author

RenaudWasTaken commented Sep 15, 2020

/retest

@dashpole
Copy link
Copy Markdown
Contributor

dashpole commented Sep 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit fd9828b into kubernetes:master Sep 15, 2020
@RenaudWasTaken RenaudWasTaken deleted the move-podresources-api branch September 19, 2020 10:16
@github-actions github-actions Bot mentioned this pull request Sep 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole Awaiting requested review from dashpole

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

@dashpole dashpole

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

API Reviews
Status: API review completed, 1.20

Milestone

v1.20

Development

Successfully merging this pull request may close these issues.

9 participants

@RenaudWasTaken @fejta-bot @SergeyKanzhelev @dashpole @liggitt @neolit123 @k8s-ci-robot @dims @justaugustus