Adding IngressClass to networking/v1beta1#88509
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Mar 2, 2020
Merged
Adding IngressClass to networking/v1beta1#88509k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
f9269a9 to
7e229f4
Compare
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
7e229f4 to
d7101b7
Compare
This was referenced Feb 25, 2020
sftim
reviewed
Feb 25, 2020
Contributor
|
/cc @liggitt |
64e30f6 to
c50d833
Compare
c50d833 to
a1185b8
Compare
Member
Author
00a8d58 to
9eb8c3f
Compare
Member
Author
|
/retest |
liggitt
reviewed
Mar 2, 2020
Co-authored-by: Christopher M. Luciano <cmluciano@us.ibm.com>
9eb8c3f to
132d2af
Compare
Member
|
/test pull-kubernetes-conformance-kind-ga-only |
Member
|
/retest |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
Member
|
/hold cancel |
Contributor
|
@robscott: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
41 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This builds on the initial PR filed to graduate Ingress to v1. It has become clear that the scope of changes was too large to fit into a graduation to v1. This PR takes the IngressClass portion of that PR and adds it to v1beta1 in preparation for graduation to v1 in 1.19.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @cmluciano
/sig network
/priority important-soon