Skip to content

Remove ability to re-enable serving deprecated APIs#85903

Merged
k8s-ci-robot merged 8 commits intokubernetes:masterfrom
liggitt:disable-deprecated-apis
Dec 14, 2019
Merged

Remove ability to re-enable serving deprecated APIs#85903
k8s-ci-robot merged 8 commits intokubernetes:masterfrom
liggitt:disable-deprecated-apis

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Dec 4, 2019 •
edited
Loading

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
Removes ability to re-enable serving deprecated extensions/v1beta1, apps/v1beta1, and apps/v1beta2 types

Which issue(s) this PR fixes:
xref #43214

Does this PR introduce a user-facing change?:

kube-apiserver no longer serves the following deprecated APIs:
* All resources under `apps/v1beta1` and `apps/v1beta2` - use `apps/v1` instead
* `daemonsets`, `deployments`, `replicasets` resources under `extensions/v1beta1` - use `apps/v1` instead
* `networkpolicies` resources under `extensions/v1beta1` - use `networking.k8s.io/v1` instead
* `podsecuritypolicies` resources under `extensions/v1beta1` - use `policy/v1beta1` instead

/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2019
@liggitt liggitt force-pushed the disable-deprecated-apis branch from 443fe3f to 1ed4db8 Compare December 4, 2019 14:14
@liggitt liggitt changed the title WIP - Disable deprecated apis WIP - Remove ability to re-enable serving deprecated APIs Dec 4, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 4, 2019
@liggitt liggitt force-pushed the disable-deprecated-apis branch from 1ed4db8 to 779a067 Compare December 4, 2019 14:30
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 4, 2019
@liggitt liggitt force-pushed the disable-deprecated-apis branch from 1914f49 to 591749d Compare December 4, 2019 15:46
@liggitt liggitt changed the title WIP - Remove ability to re-enable serving deprecated APIs Remove ability to re-enable serving deprecated APIs Dec 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2019
@liggitt liggitt force-pushed the disable-deprecated-apis branch from 591749d to 2bc22a9 Compare December 4, 2019 15:50
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Dec 4, 2019
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Dec 4, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Dec 4, 2019

/retest

@soltysh soltysh mentioned this pull request Dec 4, 2019
Closed
41 tasks
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Dec 10, 2019

/retest

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Dec 13, 2019

looks ok to me, rebase and I'll tag. double checked the messages to consumers in previous changelogs to make sure we were consistent

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2019
@liggitt liggitt force-pushed the disable-deprecated-apis branch from 9b45285 to 5c63715 Compare December 13, 2019 17:23
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Dec 13, 2019 •
edited
Loading

rebased and updated release note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 13, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 13, 2019 •
edited
Loading

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd 5c63715 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-gci-gce-autoscaling 5c63715 link /test pull-kubernetes-e2e-gci-gce-autoscaling
pull-kubernetes-e2e-gce-device-plugin-gpu 5c63715 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Dec 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a919f2 into kubernetes:master Dec 14, 2019
@liggitt liggitt deleted the disable-deprecated-apis branch December 16, 2019 20:22
@prasadkatti prasadkatti mentioned this pull request Mar 31, 2020
Closed
This was referenced Apr 24, 2020
Merged
Merged
@liggitt liggitt mentioned this pull request Apr 24, 2020
Merged
@s-ito-ts s-ito-ts mentioned this pull request May 12, 2020
Closed
@k-toyoda-pi k-toyoda-pi mentioned this pull request Jul 15, 2020
Closed
@soltysh soltysh mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

5 participants

@liggitt @fejta-bot @fedebongio @smarterclayton @k8s-ci-robot