Skip to content

chore: replace init scripts with a dependency on itself#3674

Merged
johnjbarton merged 1 commit intokarma-runner:masterfrom
devoto13:remove-init
Apr 12, 2021
Merged

chore: replace init scripts with a dependency on itself#3674
johnjbarton merged 1 commit intokarma-runner:masterfrom
devoto13:remove-init

Conversation

@devoto13
Copy link
Copy Markdown
Collaborator

This has the same result (symlink to the karma in the node_modules), but has two benefits:

  • karma developers don't need to run extra command
  • no peer dependency warnings when npm install is run

This has the same result (symlink to the `karma` in the node_modules), but has two benefits:

- karma developers don't need to run extra command
- no peer dependency warnings when `npm install` is run
@karmarunnerbot
Copy link
Copy Markdown
Member

Build karma 577 completed (commit d6386a3a5c by @devoto13)

@karmarunnerbot
Copy link
Copy Markdown
Member

Build karma 578 completed (commit d6386a3a5c by @devoto13)

@devoto13 devoto13 requested a review from johnjbarton April 11, 2021 22:23
Copy link
Copy Markdown
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@johnjbarton johnjbarton merged commit cc9420d into karma-runner:master Apr 12, 2021
@devoto13 devoto13 deleted the remove-init branch May 4, 2021 14:33
@karmarunnerbot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
…er#3674)

This has the same result (symlink to the `karma` in the node_modules), but has two benefits:

- karma developers don't need to run extra command
- no peer dependency warnings when `npm install` is run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants