Skip to content

[Fix] no-unknown-property: onError and onLoad on <picture> and <iframe> elements#3398

Merged
ljharb merged 1 commit intojsx-eslint:masterfrom
maiis:no-unknown-property-picture-element
Sep 5, 2022
Merged

[Fix] no-unknown-property: onError and onLoad on <picture> and <iframe> elements#3398
ljharb merged 1 commit intojsx-eslint:masterfrom
maiis:no-unknown-property-picture-element

Conversation

@maiis
Copy link
Copy Markdown
Contributor

@maiis maiis commented Sep 5, 2022 •
edited
Loading

This PR adds:

  • allows onError and onLoad property on <picture> element
  • allows onError and onLoad property on <iframe> element

@maiis maiis changed the title [Fix] no-unknown-property: allowed on element [Fix] no-unknown-property: allowed on <picture> element Sep 5, 2022
@maiis maiis changed the title [Fix] no-unknown-property: allowed on <picture> element [Fix] no-unknown-property: onError and onLoad on <picture> element Sep 5, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #3398 (5669fdb) into master (1c0c92b) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 5669fdb differs from pull request most recent head 033fcc5. Consider uploading reports for the commit 033fcc5 to get more accurate results

@@            Coverage Diff             @@
##           master    #3398      +/-   ##
==========================================
- Coverage   97.58%   97.42%   -0.17%     
==========================================
  Files         123      123              
  Lines        8958     8958              
  Branches     3270     3270              
==========================================
- Hits         8742     8727      -15     
- Misses        216      231      +15
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.83% <ø> (ø)
lib/rules/no-unused-state.js 93.51% <0.00%> (-5.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@archiii92
Copy link
Copy Markdown

archiii92 commented Sep 5, 2022 •
edited
Loading

Could you, please, also add 'onError' and 'onLoad' on <iframe> element?

@maiis maiis changed the title [Fix] no-unknown-property: onError and onLoad on <picture> element [Fix] no-unknown-property: onError and onLoad on <picture> and <iframe> elements Sep 5, 2022
@maiis @akx @ljharb
[Fix] no-unknown-property: add onError and onLoad for iframe/picture
033fcc5 
Fixes #3410.

Co-authored-by: Emmanuel Vuigner <hi@maiis.me>
Co-authored-by: Aarni Koskela <akx@iki.fi>
This was referenced Sep 5, 2022
Merged
Closed
Merged
@ljharb ljharb merged commit 033fcc5 into jsx-eslint:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maiis @archiii92 @ljharb