Deprecate jsx-space-before-closing rule#1070
Merged
yannickcr merged 1 commit intojsx-eslint:masterfrom Apr 23, 2017
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #967
As discussed in #693 (comment), the
react/jsx-space-before-closingcan now be deprecated in favour ofreact/jsx-tag-spacingwhich offers a superset of its functionality.This PR marks the old rule as deprecated and triggers a warning where it is still being used, reusing some code from the also deprecated
react/require-extensionrule.Let me know if I've missed any steps in the deprecation process!