[Fix] jsx-no-constructed-context-values: fix false positive for usage in non-components#3448
Merged
ljharb merged 1 commit intojsx-eslint:masterfrom Oct 3, 2022
Merged
Conversation
…ge in non-components Fixes jsx-eslint#3295
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 123 123
Lines 8974 8976 +2
Branches 3278 3279 +1
=======================================
+ Hits 8761 8763 +2
Misses 213 213
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
56c2b73 to
6f12ee6
Compare
ljharb
approved these changes
Oct 3, 2022
| }, | ||
| { | ||
| code: '<Context.Provider value="Some string"></Context.Provider>', | ||
| code: 'const Component = () => <Context.Provider value="Some string"></Context.Provider>', |
Member
There was a problem hiding this comment.
presumably all of these existing test cases would still pass with this change?
Contributor
Author
There was a problem hiding this comment.
Yes, I change it because otherwise these test cases would pass because they are not in components, not because other any reason which is supposed to be tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3295