fix(deps): rollback klaw to 3.x#2002
Merged
Merged
Conversation
1 task
This was referenced Jul 20, 2022
Fool256
approved these changes
Jul 22, 2025
Fool256
approved these changes
Jul 22, 2025
Fool256
approved these changes
Jul 22, 2025
Fool256
approved these changes
Jul 22, 2025
Fool256
approved these changes
Jul 22, 2025
Fool256
approved these changes
Jul 22, 2025
Fool256
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #2000, pulling
klawv4 makesjsdocrequire Node.js v14.Background:
jsdocis a runtime dependency ofprotobufjs-cli(it may sound weird, butjsdocis used to generate.d.tsfiles from the proto files, and is used bypbtstool). So, since Google Cloud client libraries usepbts, this change madegoogle-gaxand the client libraries require Node.js v14, but we still want to support Node.js v12 for some time.I think this change is not intentional, so we suggest that the 3.6.x branch should still depend on
klawv3.@hegemonic, what do you think?
Thank you!