Skip to content

Fix tests on Node 14#800

Merged
RyanZim merged 2 commits intomasterfrom
ryan/fix-tests-14
May 14, 2020
Merged

Fix tests on Node 14#800
RyanZim merged 2 commits intomasterfrom
ryan/fix-tests-14

Conversation

@RyanZim
Copy link
Copy Markdown
Collaborator

@RyanZim RyanZim commented May 14, 2020

Fixes #798

writeFileSync requires a data parameter

Also add Node 14 to CI

@RyanZim RyanZim requested a review from manidlou May 14, 2020 00:54
@manidlou
Copy link
Copy Markdown
Collaborator

@RyanZim thank you for taking care of this quickly! I think the issue number in description should be #798?!

RyanZim added 2 commits May 14, 2020 10:09
Fixes #798

writeFileSync requires a data parameter
@RyanZim RyanZim force-pushed the ryan/fix-tests-14 branch from 235aa03 to 430d793 Compare May 14, 2020 14:09
@RyanZim
Copy link
Copy Markdown
Collaborator Author

RyanZim commented May 14, 2020

@manidlou Good catch, updated, and forced-pushed to fix commit message as well.

@RyanZim RyanZim merged commit 28173ed into master May 14, 2020
@RyanZim RyanZim deleted the ryan/fix-tests-14 branch May 14, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some tests are failing in node.js 14

2 participants