Remove padding from JWK test data.#628
Merged
jpadilla merged 3 commits intojpadilla:masterfrom Mar 18, 2021
Merged
Conversation
jpadilla
reviewed
Mar 14, 2021
Owner
jpadilla
left a comment
There was a problem hiding this comment.
Any specific reason this is required?
Contributor
Author
|
Thanks for checking this PR. base64url encoding can skip padding("="). Many jwk implementations that I know of omit the padding, and I thought that test data would be better suited to the common implementation. However, skipping padding is not mandatory so I'll leave it up to you to decide if you want to accept this PR. |
jpadilla
approved these changes
Mar 18, 2021
Owner
jpadilla
left a comment
There was a problem hiding this comment.
Thanks, can you add this to the CHANGELOG?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.