Validate claims if configured and verify_signature is not.#608
Merged
jpadilla merged 3 commits intojpadilla:masterfrom Feb 15, 2021
Natim:bug/599/validate_claims_doesnt_requires_validate_signature
Merged
Validate claims if configured and verify_signature is not.#608jpadilla merged 3 commits intojpadilla:masterfrom Natim:bug/599/validate_claims_doesnt_requires_validate_signature
jpadilla merged 3 commits intojpadilla:masterfrom
Natim:bug/599/validate_claims_doesnt_requires_validate_signature
Conversation
glaucimar
reviewed
Jan 22, 2021
glaucimar
left a comment
There was a problem hiding this comment.
This definitely fixes my issue and my need too.
Contributor
Author
|
@jpadilla what do you think? |
jpadilla
approved these changes
Feb 3, 2021
Owner
jpadilla
left a comment
There was a problem hiding this comment.
Awesome, thanks! Could you add to the changelog as well?
Contributor
Author
|
I added a changelog entry, hope it's good enough. |
Contributor
Author
|
@jpadilla I'm sorry to bug you about this, would you be able to make a release for this fix? |
Contributor
Author
|
@jpadilla I'm sorry to bug you about this, would you be able to make a release for this fix? |
Contributor
Author
|
@jpadilla any idea of what I can do to help about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599