Null-check cleanable in Memory#close#1447
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me - sorry, that I did not catch that.
It might be good to cut a point release after this - what do you think?
Agreed. Should be faster without the need to rebuild the binaries, right? |
Yes, rebuilding binaries takes about a day, doing a release that only requires a java build is a matter of minutes (see https://github.com/java-native-access/jna/blob/master/www/ReleasingJNA.md) |
I'd be happy to see a quick point release now. I need to do a point release on my own project soon so it'd be nice to update this as well.
It was rather subtle! Thanks for helping identify the root cause. |
|
If you want here is a snapshot repository: https://oss.sonatype.org/content/repositories/snapshots/ where 5.12.1-SNAPSHOT is present. If you can test with that it would be good, but if not, just say so, than I'll push the release tonight. |
|
Tested with the snapshot, looks good. |
|
Release is done - maven central sync should happen shortly. Thanks again for catching this so quickly. |
Fixes #1446