Skip to content

Include typings in npm distribution#43

Merged
janl merged 1 commit intojanl:masterfrom
FabianFrank:fix-typings
Jul 3, 2020
Merged

Include typings in npm distribution#43
janl merged 1 commit intojanl:masterfrom
FabianFrank:fix-typings

Conversation

@FabianFrank
Copy link
Copy Markdown
Contributor

fixes #36

After this change you can see that npm includes the types:

$ npm pack
[...]
npm notice === Tarball Contents ===
npm notice 974B  package.json
npm notice 699B  jsonpointer.d.ts
npm notice 2.3kB jsonpointer.js
npm notice 1.2kB LICENSE.md
npm notice 1.3kB README.md
[...]

whereas before it wasn't.

@FabianFrank
Copy link
Copy Markdown
Contributor Author

@janl any chance that we can merge this?

@reckter
Copy link
Copy Markdown
Contributor

reckter commented Apr 22, 2020

Hey, Is there any plan on merging this? typescript support would be awesome :)

@janl janl merged commit a4c6115 into janl:master Jul 3, 2020
@janl
Copy link
Copy Markdown
Owner

janl commented Jul 3, 2020

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@janl janl added the released label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does the typescript typings file work?

4 participants