zeroize: Add explicit array impls for DefaultIsZeroes#184
Merged
tony-iqlusion merged 1 commit intodevelopfrom May 19, 2019
Merged
zeroize: Add explicit array impls for DefaultIsZeroes#184tony-iqlusion merged 1 commit intodevelopfrom
tony-iqlusion merged 1 commit intodevelopfrom
Conversation
When zeroing either [Z] or [Z; N], where `Z: DefaultIsZeroes`, i.e. a contiguous memory region we want to fill with `Z::default()` we can (at such a time it becomes available) take advantage of using an atomic memset-like implementation which can be implemented efficiently. This change adds explicit bounds for arrays of up to size 64, and relaxes the `IterMut` bounds from `DefaultIsZeroes` to `Zeroize`, allowing it to be the fallback "slow mode" for dealing with cases where a fast path isn't available. TODO: Const generics
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When zeroing either
[Z]or[Z; N], whereZ: DefaultIsZeroes, i.e. a contiguous memory region we want to fill withZ::default()we can (at such a time it becomes available) take advantage of using an atomicmemset-like implementation which can be implemented efficiently.This change adds explicit bounds for arrays of up to size 64, and relaxes the
IterMutbounds fromDefaultIsZeroestoZeroize, allowing it to be the fallback "slow mode" for dealing with cases where a fast path isn't available.TODO: Const generics