zeroize: Remove 'nightly' feature#183
Merged
tony-iqlusion merged 1 commit intodevelopfrom May 19, 2019
Merged
Conversation
d6d1ccc to
14799e1
Compare
Zeroize previously provided a 'nightly' feature which used a slightly more complex implementation in order to facilitate a micro-optimization. However, the extra complexity was never justified, nor does it represent the desired path forward on nightly (which would be to use atomic writes instead of volatile writes, when they become available but aren't yet stabilized). It also seems some impls are missing, particularly for arrays, in which case the special-case nightly impls become more cumbersome. This commit rips out the entire nightly feature and ensures the crate behaves the same way everywhere regardless of Rust channel.
14799e1 to
ebc8531
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zeroize previously provided a 'nightly' feature which used a slightly more complex implementation in order to facilitate a micro-optimization: namely it used volatile_set_memory on
nightlyto efficiently byte slices (which typically thunks tomemset()followed by a fence instruction).However, the extra complexity was never justified through benchmarking, nor does it represent the desired path forward on nightly (which would be to use atomic writes instead of volatile writes, when they become available but aren't yet stabilized).
It also seems some
Zeroizeimpls are missing, particularly for arrays, in which case the special-case nightly impls become more cumbersome.This commit rips out the entire nightly feature and ensures the crate behaves the same way everywhere regardless of Rust channel.