Add 'normalize' argument to Audio to make normalization optional#11650
Merged
Carreau merged 7 commits intoipython:masterfrom Mar 19, 2019
Merged
Add 'normalize' argument to Audio to make normalization optional#11650Carreau merged 7 commits intoipython:masterfrom
Carreau merged 7 commits intoipython:masterfrom
Conversation
numpy is included in the test requirements; tests requiring numpy can always be run.
Member
|
That looks good to me, thanks ! Apologies for the delay in reviewing, and welcome to the party ! |
Contributor
Author
|
Great :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8608. Based on #11161 with changes as discussed (see comment).
It might be easier to review each commit separately in this PR.
While working on the fix, I encountered and fixed the following small bugs: