Skip to content

Exclude --configuration from PhpUnit options#941

Merged
maks-rafalko merged 1 commit intoinfection:masterfrom
duncan3dc:phpunit-configuration-override-fix
Jan 2, 2020
Merged

Exclude --configuration from PhpUnit options#941
maks-rafalko merged 1 commit intoinfection:masterfrom
duncan3dc:phpunit-configuration-override-fix

Conversation

@duncan3dc
Copy link
Copy Markdown
Contributor

@duncan3dc duncan3dc commented Jan 2, 2020

This PR:

If you run infection --test-framework-options="--configuration=custom.xml" then no mutations are detected as the generated configuration is overridden and regular autoloading is used.

Copy link
Copy Markdown
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Am I right that this PR does not solve this issue though?

@duncan3dc
Copy link
Copy Markdown
Contributor Author

That's correct, it does not solve that issue

@maks-rafalko maks-rafalko added this to the 0.16.0 milestone Jan 2, 2020
@maks-rafalko maks-rafalko merged commit 8d482e7 into infection:master Jan 2, 2020
@maks-rafalko
Copy link
Copy Markdown
Member

Thank you @duncan3dc

@duncan3dc duncan3dc deleted the phpunit-configuration-override-fix branch January 2, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants