Skip to content

Add Symfony PHPUnitBridge#755

Merged
theofidry merged 3 commits intoinfection:masterfrom
theofidry:feature/phpunit-bridge
Jul 25, 2019
Merged

Add Symfony PHPUnitBridge#755
theofidry merged 3 commits intoinfection:masterfrom
theofidry:feature/phpunit-bridge

Conversation

@theofidry
Copy link
Copy Markdown
Member

@theofidry theofidry commented Jul 24, 2019

This allows to:

  • Fail hard if our code is using (direct) deprecated code
  • Add a coverage listener which should improve how the coverage is measured

maks-rafalko
maks-rafalko requested changes Jul 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the coverage listener

However, tests fail https://travis-ci.org/infection/infection/jobs/563212194#L959

@theofidry theofidry force-pushed the feature/phpunit-bridge branch from 84332f1 to 5a9e8df Compare July 24, 2019 21:00
@theofidry theofidry requested a review from maks-rafalko July 24, 2019 21:00
@theofidry
Copy link
Copy Markdown
Member Author

theofidry commented Jul 24, 2019

What is the purpose of the test failed label? The CI state is now available in the PR list so it looks redundant and a bit annoying since needs to be handled manually

@maks-rafalko
Copy link
Copy Markdown
Member

maks-rafalko commented Jul 25, 2019 •
edited
Loading

What is the purpose of the test failed label?

Very often, CI state is red because of MSI which we are not trying to increase for existing files. And I don't want to open Travis and see why the buids are failed, because of MSI or because of other issues (tests, etc.).

That's why it's easier to mark it as Tests Failed unless PR author fixes all the issues.

I've added it when one day I merged broken code to the master branch because I was too lazy to open Travis to see what is the reason of red status for the N-th time.

@maks-rafalko maks-rafalko added this to the 0.14.0 milestone Jul 25, 2019
@theofidry theofidry merged commit f915c7f into infection:master Jul 25, 2019
@theofidry theofidry deleted the feature/phpunit-bridge branch July 25, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@theofidry @maks-rafalko