Allow to configure ignore globally#1104
Conversation
Co-Authored-By: Alexey Kopytko <alexey@kopytko.com>
|
Is it not possible atm to set an |
|
@BackEndTea it is but the default is not necessarily all the mutators |
There was a problem hiding this comment.
Nice.
Let's write detailed documentation for this new feature with examples for
This PR proposes to allow a global ignore config which will be enriched (not overwritten) by each mutators.
I mean, docs should clearly state that ignore configs will be merged, not overridden, to avoid any confusion.
|
|
||
| /** | ||
| * @param array<string, string>|bool|stdClass $settings | ||
| * @param array<string, array<string, string>> $mutators |
There was a problem hiding this comment.
Hm actually lemme double check that again
|
Hm.. I know why I hasn't noticed docs PR, its for your fork: https://github.com/theofidry/site/pull/1/files. I've updated first message to include information about docs, please update with |
|
sight stupid me, thanks will update the PR tonight |
As of now, if you want to add an
ignoresetting, you need to add it on a mutator basis. This however gets seriously tedious, repetitive and hard to keep in sync if you have a lot of mutators listed.This PR proposes to allow a global ignore config which will be enriched (not overwritten) by each mutators.