Skip to content

Introduce ConfigurableMutator#1012

Merged
theofidry merged 28 commits intoinfection:masterfrom
theofidry:feature/configurable-mutator
Feb 17, 2020
Merged

Introduce ConfigurableMutator#1012
theofidry merged 28 commits intoinfection:masterfrom
theofidry:feature/configurable-mutator

Conversation

@theofidry
Copy link
Copy Markdown
Member

Depends on #1005

This PR introduces an abstraction to allow a bit more of flexibility for introducing a configurable mutator:

  • A configurable mutator should implement ConfigurableMutator which requires to declare the getConfigClassName() method
  • The GetConfigClassName which can be used default the config to being \...\MutatorClassNameConfig
  • A MutatorConfig interface which each config needs to implement and force how a config should be instantiated
  • More mutator related autoreview tests to ensure all the above is done correctly

@theofidry theofidry requested a review from sanmai February 12, 2020 08:58
@theofidry theofidry marked this pull request as ready for review February 12, 2020 08:58
@theofidry
Copy link
Copy Markdown
Member Author

ping @infection/core

Copy link
Copy Markdown
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Comment thread src/Mutator/MutatorFactory.php
Comment thread src/Mutator/MutatorFactory.php
@theofidry theofidry merged commit 4888643 into infection:master Feb 17, 2020
@theofidry theofidry deleted the feature/configurable-mutator branch February 17, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants