ConvBERT: minor fixes for conversion script#9937
Merged
LysandreJik merged 1 commit intohuggingface:masterfrom Feb 2, 2021
stefan-it:convbert-fix-clean
Merged
ConvBERT: minor fixes for conversion script#9937LysandreJik merged 1 commit intohuggingface:masterfrom stefan-it:convbert-fix-clean
LysandreJik merged 1 commit intohuggingface:masterfrom
stefan-it:convbert-fix-clean
Conversation
Collaborator
Author
|
Pinging @abhishekkrthakur and @sgugger 🤗 |
sgugger
approved these changes
Feb 1, 2021
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
The imports are correct this way. I'll defer to @abhishekkrthakur for the other change.
Thanks for your PR!
Contributor
|
Weird that relative imports failed. Anyways, thanks for the PR. The model_type in hub has been fixed. |
abhishekkrthakur
approved these changes
Feb 2, 2021
LysandreJik
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
the conversion script for ConvBERT throws the following error message when using it:
I fixed that error, as well as using the correct name for the configuration file argument.
Additionally, I just found that the configuration files from the YituTech organization for ConvBERT from aren't correct, because they use:
instead of:
(This currently results in a
KeyError: 'conv_bert'error).