Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #600
As we manually implement
SerializeandDeserializefor the various models, we didn't include the#[serde(tag = "type")]we use everywhere else, so when deserializing we can only know what Model it is based on the various fields we see.This used to work fine as long as these models were different enough, but it is not the case anymore with
WordPieceandWordLevelthat can be deserialized from the same serialized json.This PR fixes this by adding the
typein the serialization process, and using it if it is defined. This is also backward compatible because we don't make it mandatory, but we add a layer of verification based on the presence of the fields (mainly forWordPieceandWordLevel).