Improve deploy key and user key handling#1616
Merged
bitwiseman merged 2 commits intohub4j:mainfrom Feb 26, 2023
jvv-trackunit:feature/improve-deploy-key-functionality
Merged
Improve deploy key and user key handling#1616bitwiseman merged 2 commits intohub4j:mainfrom jvv-trackunit:feature/improve-deploy-key-functionality
bitwiseman merged 2 commits intohub4j:mainfrom
jvv-trackunit:feature/improve-deploy-key-functionality
Conversation
feat(personal SSH key): Added method to allow adding/deleting public keys on a user Added test cases to cover all new functionality.
10 tasks
Codecov ReportBase: 79.30% // Head: 79.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
============================================
+ Coverage 79.30% 79.50% +0.19%
- Complexity 2142 2154 +12
============================================
Files 206 206
Lines 6582 6601 +19
Branches 364 364
============================================
+ Hits 5220 5248 +28
+ Misses 1150 1141 -9
Partials 212 212
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bitwiseman
approved these changes
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE:
This is a copy of #1593 made from a personal account to allow "Allow edits from maintainers". The code is similar - the commits have been rebased and squashed onto latest main though.
Description
Added additional fields to deploykey object: created_at, last_used, added_by, read_only.
Added methods to allow adding / deleting public keys on a user.
Before submitting a PR:
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: