Filter check runs to retrieve from commit#1612
Merged
bitwiseman merged 7 commits intohub4j:mainfrom Feb 25, 2023
alecharp:feature/filter-check-runs-on-commit
Merged
Filter check runs to retrieve from commit#1612bitwiseman merged 7 commits intohub4j:mainfrom alecharp:feature/filter-check-runs-on-commit
bitwiseman merged 7 commits intohub4j:mainfrom
alecharp:feature/filter-check-runs-on-commit
Conversation
Codecov ReportBase: 79.22% // Head: 79.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
============================================
+ Coverage 79.22% 79.30% +0.07%
- Complexity 2141 2142 +1
============================================
Files 206 206
Lines 6576 6582 +6
Branches 364 364
============================================
+ Hits 5210 5220 +10
+ Misses 1154 1150 -4
Partials 212 212
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alecharp
added a commit
to alecharp/plugin-health-scoring
that referenced
this pull request
Feb 2, 2023
10 tasks
Contributor
Author
|
@bitwiseman do you think this is good enough to be merged and have a release of the library? |
Member
|
@alecharp Sorry for the delay. I'll get a release out tonight. |
Contributor
Author
|
No problem @bitwiseman. thank you very much for this PI release ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-for-a-git-reference, there are parameters we can provide to filter the Check which are retrieved.
Creating a method for each parameter didn't seem like a good idea, so I just inject potential parameters on the request.
Before submitting a PR:
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: