Incorrect project version downgrade#1611
Merged
bitwiseman merged 1 commit intohub4j:mainfrom Feb 3, 2023
alecharp:fix/incorrect-project-version
Merged
Incorrect project version downgrade#1611bitwiseman merged 1 commit intohub4j:mainfrom alecharp:fix/incorrect-project-version
bitwiseman merged 1 commit intohub4j:mainfrom
alecharp:fix/incorrect-project-version
Conversation
This was introduced in 30ff8e6 and I believe it is a mistake
Codecov ReportBase: 79.22% // Head: 79.22% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=========================================
Coverage 79.22% 79.22%
Complexity 2141 2141
=========================================
Files 206 206
Lines 6576 6576
Branches 364 364
=========================================
Hits 5210 5210
Misses 1154 1154
Partials 212 212 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
@bitwiseman is there anything I can help with to get this and #1612 merged and have a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in 30ff8e6 and I believe it is a mistake
Description
Project version was downgraded to
1.312-SNAPSHOTwhen the project already has releases for1.312and1.313.Before submitting a PR:
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: