Use https in example GitHub Enterprise URL in Javadocs#1521
Merged
bitwiseman merged 1 commit intohub4j:mainfrom Sep 27, 2022
Merged
Use https in example GitHub Enterprise URL in Javadocs#1521bitwiseman merged 1 commit intohub4j:mainfrom
bitwiseman merged 1 commit intohub4j:mainfrom
Conversation
I just spent a few hours banging my head against some mysterious errors that were resolved by using an https-based URL instead of an http one. I had copied from the Javadocs example URL and replaced the domain name, and did not notice that it started with `http:`. Use `https:` in the example instead, as that is more likely what people want.
gsmet
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just spent a few hours banging my head against some mysterious errors that were resolved by using an https-based URL instead of an http one. I had copied from the Javadocs example URL and replaced the domain name, and did not notice that it started with
http:.Use
https:in the example instead, as that is more likely what people want.Description
In the Javadocs for
GitHubBuilder.withEndpoint, edit the example URL for GitHub Enterprise to usehttps:rather thanhttp:.Before submitting a PR:
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: