MySQL physical backend implementation#324
MySQL physical backend implementation#324armon merged 5 commits intohashicorp:masterfrom pradeepchhetri:master
Conversation
There was a problem hiding this comment.
You probably only need to put the errors that are used more than once at this level. The single use errors can just be defined at the call site.
|
Left some comments, but this is looking on the right track! |
|
Hello @armon !! I updated things as per your suggestions except following things:
Can you please look into the code once again and see if it looks as per your comments. |
|
@armon I was able to build and run the tests. One test which is trying to select the value for key when the key doesn't exists is still failing otherwise other tests are working fine. Can you suggest me how should i solve that ? |
|
Fixed the failing test. Can you please review once again. |
There was a problem hiding this comment.
This looks suspect, I think we need to properly use the mysql escaping to avoid an issue with prefix being an attack vector
There was a problem hiding this comment.
@armon I am unable to figure out how to do mysql escaping. Can you provide me link of some example. Sorry to bother you.
|
@pradeepchhetri Looking good, just one minor issue with List |
|
@pradeepchhetri I merged this and made some minor cleanups. Thanks! |
|
@armon Thank you for all the feedbacks. Learnt a lot :) |
I am new to Golang. I followed the logic in existing backends and tried to port it for MySQL. I am not sure if having MySQL as one of the physical makes sense or not. Kindly please review the code and provide me feedback.
Thank you !!