Skip to content

Add ability to read raw field from secret#257

Merged
armon merged 2 commits intohashicorp:masterfrom
ianunruh:feature/read-field
May 22, 2015
Merged

Add ability to read raw field from secret#257
armon merged 2 commits intohashicorp:masterfrom
ianunruh:feature/read-field

Conversation

@ianunruh
Copy link
Copy Markdown
Contributor

Fixes #243

@armon
Copy link
Copy Markdown
Contributor

armon commented May 22, 2015

@ianunruh LGTM! Thanks!

armon added a commit that referenced this pull request May 22, 2015
Add ability to read raw field from secret
@armon armon merged commit 5562fe6 into hashicorp:master May 22, 2015
@armon
Copy link
Copy Markdown
Contributor

armon commented May 22, 2015

@jefferai This may be of interest

@jefferai
Copy link
Copy Markdown
Member

@armon Definitely useful in a general sense, but doesn't help with CRLs or CA certificate fetching, since random client X will reference a URL and expect a bare CRL.

It also doesn't really help, currently, with certificate/private key fetching because those are in two fields, although I could turn them into a bundle so that you can get the full bare bundle with this functionality. There is some sense in doing that, as when you're doing this programmatically via Vault it seems reasonable that you'll either read the values into memory and then discard them, or simply write them into a private file. Or, maybe even better, make this a flag that is toggleable when requesting the cert.

Tagging #125 to help me remember. Also there is a long post waiting for responses there :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extracting secret value back to file

3 participants