Physical S3 backend implementation#242
Merged
armon merged 3 commits intohashicorp:masterfrom May 21, 2015
jstremick:f-physical-s3-backend
Merged
Physical S3 backend implementation#242armon merged 3 commits intohashicorp:masterfrom jstremick:f-physical-s3-backend
armon merged 3 commits intohashicorp:masterfrom
jstremick:f-physical-s3-backend
Conversation
Author
|
Implements #120 |
Author
|
Looks like I've broken tests for a few other physical backends when testing recursive deletes. Let me know what the expected behavior should be and I'll update. The S3Backend tests fail without credentials. Should I do anything about that? |
Contributor
There was a problem hiding this comment.
This should not be the case actually. This is invalid. If "foo" is deleted, only that key should be. The directories under should not be affected.
Contributor
|
@jstremick I've left some feedback, but this is looking really good! |
armon
added a commit
that referenced
this pull request
May 21, 2015
Physical S3 backend implementation
Closed
Contributor
|
@jstremick Awesome, thanks! |
Author
|
@armon Welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new 's3' physical backend to store vault data in an S3 bucket.
Notes:
Recursive delete test added. Looking at the other backends, it looks like if a key is deleted that any child keys should also be deleted.No HA support as the eventually consistent nature of S3 means acquiring locks via bucket isn't feasible. Maybe SimpleDB or another synchronous service could provide that ability?
I updated godeps.json
should I also commit the libraries it updated?and aws-sdk-go.